netdev - Re: [PATCH] ip_sockglue: Fix missing-check bug in ip_ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190525.110102.183178868031173654.davem@davemloft.net>
Date:   Sat, 25 May 2019 11:01:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     blackgod016574@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, ast@...nel.org,
        daniel@...earbox.net, kafai@...com, songliubraving@...com,
        yhs@...com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH] ip_sockglue: Fix missing-check bug in ip_ra_control()

From: Gen Zhang <blackgod016574@...il.com>
Date: Fri, 24 May 2019 11:24:26 +0800

> In function ip_ra_control(), the pointer new_ra is allocated a memory 
> space via kmalloc(). And it is used in the following codes. However, 
> when  there is a memory allocation error, kmalloc() fails. Thus null 
> pointer dereference may happen. And it will cause the kernel to crash. 
> Therefore, we should check the return value and handle the error.
> 
> Signed-off-by: Gen Zhang <blackgod016574@...il.com>

Applied.