netdev - Re: [PATCH net-next 00/11] inet: frags: avoid possible races at netns dismantle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 May 2019 14:26:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 00/11] inet: frags: avoid possible races at
 netns dismantle

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 24 May 2019 09:03:29 -0700

> This patch series fixes a race happening on netns dismantle with
> frag queues. While rhashtable_free_and_destroy() is running,
> concurrent timers might run inet_frag_kill() and attempt
> rhashtable_remove_fast() calls. This is not allowed by
> rhashtable logic.
> 
> Since I do not want to add expensive synchronize_rcu() calls
> in the netns dismantle path, I had to no longer inline
> netns_frags structures, but dynamically allocate them.
> 
> The ten first patches make this preparation, so that
> the last patch clearly shows the fix.
> 
> As this patch series is not exactly trivial, I chose to
> target 5.3. We will backport it once soaked a bit.

Ok, applied to net-next.

Everything except the last patch looks trivially correct to me.