netdev - RE: [EXT] Re: [PATCH net,stable 1/1] net: fec: add defer probe for of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB36002FA05E1C053B00D9EBD7FF1D0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Mon, 27 May 2019 01:31:59 +0000
From:   Andy Duan <fugang.duan@....com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "baruch@...s.co.il" <baruch@...s.co.il>
Subject: RE: [EXT] Re: [PATCH net,stable 1/1] net: fec: add defer probe for
 of_get_mac_address

From: David Miller <davem@...emloft.net> Sent: Saturday, May 25, 2019 4:12 AM
> From: Andy Duan <fugang.duan@....com>
> Date: Thu, 23 May 2019 01:55:23 +0000
> 
> > @@ -3146,7 +3150,10 @@ static int fec_enet_init(struct net_device *ndev)
> >       memset(cbd_base, 0, bd_size);
> >
> >       /* Get the Ethernet address */
> > -     fec_get_mac(ndev);
> > +     ret = fec_get_mac(ndev);
> > +     if (ret)
> > +             return ret;
> 
> You're leaking the queues allocated by fec_enet_alloc_queue().

Good caught, thanks David.
I will send two patches for the V2 to fix the exisited queue memory leak.