lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190528113351.44BE460388@smtp.codeaurora.org> Date: Tue, 28 May 2019 11:33:50 +0000 (UTC) From: Kalle Valo <kvalo@...eaurora.org> To: Nathan Chancellor <natechancellor@...il.com> Cc: Amitkumar Karwar <amitkarwar@...il.com>, Siva Rebbagondla <siva8118@...il.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>, Nick Desaulniers <ndesaulniers@...gle.com>, clang-built-linux@...glegroups.com, Nathan Chancellor <natechancellor@...il.com> Subject: Re: [PATCH v2 5.2] rsi: Properly initialize data in rsi_sdio_ta_reset Nathan Chancellor <natechancellor@...il.com> wrote: > When building with -Wuninitialized, Clang warns: > > drivers/net/wireless/rsi/rsi_91x_sdio.c:940:43: warning: variable 'data' > is uninitialized when used here [-Wuninitialized] > put_unaligned_le32(TA_HOLD_THREAD_VALUE, data); > ^~~~ > drivers/net/wireless/rsi/rsi_91x_sdio.c:930:10: note: initialize the > variable 'data' to silence this warning > u8 *data; > ^ > = NULL > 1 warning generated. > > Using Clang's suggestion of initializing data to NULL wouldn't work out > because data will be dereferenced by put_unaligned_le32. Use kzalloc to > properly initialize data, which matches a couple of other places in this > driver. > > Fixes: e5a1ecc97e5f ("rsi: add firmware loading for 9116 device") > Link: https://github.com/ClangBuiltLinux/linux/issues/464 > Signed-off-by: Nathan Chancellor <natechancellor@...il.com> Patch applied to wireless-drivers.git, thanks. f57b5d85ed58 rsi: Properly initialize data in rsi_sdio_ta_reset -- https://patchwork.kernel.org/patch/10958063/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists