lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190528115555.301E760F3C@smtp.codeaurora.org> Date: Tue, 28 May 2019 11:55:50 +0000 (UTC) From: Kalle Valo <kvalo@...eaurora.org> To: Jia-Ju Bai <baijiaju1990@...il.com> Cc: pkshih@...ltek.com, davem@...emloft.net, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Jia-Ju Bai <baijiaju1990@...il.com> Subject: Re: [PATCH] rtlwifi: Fix null-pointer dereferences in error handling code of rtl_pci_probe() Jia-Ju Bai <baijiaju1990@...il.com> wrote: > *BUG 1: > In rtl_pci_probe(), when rtlpriv->cfg->ops->init_sw_vars() fails, > rtl_deinit_core() in the error handling code is executed. > rtl_deinit_core() calls rtl_free_entries_from_scan_list(), which uses > rtlpriv->scan_list.list in list_for_each_entry_safe(), but it has been > initialized. Thus a null-pointer dereference occurs. > The reason is that rtlpriv->scan_list.list is initialized by > INIT_LIST_HEAD() in rtl_init_core(), which has not been called. > > To fix this bug, rtl_deinit_core() should not be called when > rtlpriv->cfg->ops->init_sw_vars() fails. > > *BUG 2: > In rtl_pci_probe(), rtl_init_core() can fail when rtl_regd_init() in > this function fails, and rtlpriv->scan_list.list has not been > initialized by INIT_LIST_HEAD(). Then, rtl_deinit_core() in the error > handling code of rtl_pci_probe() is executed. Finally, a null-pointer > dereference occurs due to the same reason of the above bug. > > To fix this bug, the initialization of lists in rtl_init_core() are > performed before the call to rtl_regd_init(). > > These bugs are found by a runtime fuzzing tool named FIZZER written by > us. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com> Ping & Larry, is this ok to take? -- https://patchwork.kernel.org/patch/10942971/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists