netdev - Re: [PATCH 10/11] net: dsa: Use PHYLINK for the CPU/DSA ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abea8843-2e42-c18a-79ef-cef670773b03@gmail.com>
Date:   Mon, 27 May 2019 18:55:05 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Ioana Ciornei <ioana.ciornei@....com>, linux@...linux.org.uk,
        andrew@...n.ch, hkallweit1@...il.com,
        maxime.chevallier@...tlin.com, olteanv@...il.com,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        vivien.didelot@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 10/11] net: dsa: Use PHYLINK for the CPU/DSA ports



On 5/27/2019 2:22 PM, Ioana Ciornei wrote:
> For DSA switches that do not have an .adjust_link callback, aka those
> who transitioned totally to the PHYLINK-compliant API, use PHYLINK to
> drive the CPU/DSA ports.
> 
> The PHYLIB usage and .adjust_link are kept but deprecated, and users are
> asked to transition from it.  The reason why we can't do anything for
> them is because PHYLINK does not wrap the fixed-link state behind a
> phydev object, so we cannot wrap .phylink_mac_config into .adjust_link
> unless we fabricate a phy_device structure.
> 
> For these ports, the newly introduced PHYLINK_DEV operation type is
> used and the dsa_switch device structure is passed to PHYLINK for
> printing purposes.  The handling of the PHYLINK_NETDEV and PHYLINK_DEV
> PHYLINK instances is common from the perspective of the driver.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian