netdev - Re: [PATCH 07/11] net: phylink: Add PHYLINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f35604c-6047-082e-814a-72d8739fff12@gmail.com>
Date:   Mon, 27 May 2019 19:01:55 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Ioana Ciornei <ioana.ciornei@....com>, linux@...linux.org.uk,
        andrew@...n.ch, hkallweit1@...il.com,
        maxime.chevallier@...tlin.com, olteanv@...il.com,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        vivien.didelot@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 07/11] net: phylink: Add PHYLINK_DEV operation type



On 5/27/2019 2:22 PM, Ioana Ciornei wrote:
> In the PHYLINK_DEV operation type, the PHYLINK infrastructure can work
> without an attached net_device. For printing usecases, instead, a struct
> device * should be passed to PHYLINK using the phylink_config structure.
> 
> Also, netif_carrier_* calls ar guarded by the presence of a valid
> net_device. When using the PHYLINK_DEV operation type, we cannot check
> link status using the netif_carrier_ok() API so instead, keep an
> internal state of the MAC and call mac_link_{down,up} only when the link
> changed.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Should not this patch be re-ordered to be after patch #8? Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian