lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190528140105.GH18059@lunn.ch> Date: Tue, 28 May 2019 16:01:05 +0200 From: Andrew Lunn <andrew@...n.ch> To: Richard Cochran <richardcochran@...il.com> Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net>, devicetree@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>, Jacob Keller <jacob.e.keller@...el.com>, Mark Rutland <mark.rutland@....com>, Miroslav Lichvar <mlichvar@...hat.com>, Rob Herring <robh+dt@...nel.org>, Willem de Bruijn <willemb@...gle.com> Subject: Re: [PATCH V3 net-next 2/6] net: Introduce a new MII time stamping interface. On Mon, May 27, 2019 at 10:17:50PM -0700, Richard Cochran wrote: > On Wed, May 22, 2019 at 02:58:23AM +0200, Andrew Lunn wrote: > > > -static int dp83640_hwtstamp(struct phy_device *phydev, struct ifreq *ifr) > > > +static int dp83640_hwtstamp(struct mii_timestamper *mii_ts, struct ifreq *ifr) > > > { > > > - struct dp83640_private *dp83640 = phydev->priv; > > > + struct dp83640_private *dp83640 = > > > + container_of(mii_ts, struct dp83640_private, mii_ts); > > > struct hwtstamp_config cfg; > > > u16 txcfg0, rxcfg0; > > > > Hi Richard > > > > David might complain about reverse christmas tree. Maybe define a > > macro, to_dp83640() which takes mii_ts? > > That is nice idea for another series, I think. For now this matches > the existing 'container_of' usage within the driver. Well, David might reject it because it is not reverse christmas tree. Andrew
Powered by blists - more mailing lists