netdev - Re: [PATCH 03/11] net: phy: Check against net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201905281030.nUFia0e7%lkp@intel.com>
Date:   Tue, 28 May 2019 10:27:12 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     kbuild-all@...org, linux@...linux.org.uk, f.fainelli@...il.com,
        andrew@...n.ch, hkallweit1@...il.com,
        maxime.chevallier@...tlin.com, olteanv@...il.com,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        vivien.didelot@...il.com, netdev@...r.kernel.org,
        Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH 03/11] net: phy: Check against net_device being NULL

Hi Ioana,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on v5.2-rc2 next-20190524]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ioana-Ciornei/Decoupling-PHYLINK-from-struct-net_device/20190528-061507
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/net/phy/phy_device.c:952:31: sparse: sparse: incorrect type in return expression (different base types) @@    expected int @@    got voiint @@
>> drivers/net/phy/phy_device.c:952:31: sparse:    expected int
>> drivers/net/phy/phy_device.c:952:31: sparse:    got void *

vim +952 drivers/net/phy/phy_device.c

   937	
   938	/**
   939	 * phy_connect_direct - connect an ethernet device to a specific phy_device
   940	 * @dev: the network device to connect
   941	 * @phydev: the pointer to the phy device
   942	 * @handler: callback function for state change notifications
   943	 * @interface: PHY device's interface
   944	 */
   945	int phy_connect_direct(struct net_device *dev, struct phy_device *phydev,
   946			       void (*handler)(struct net_device *),
   947			       phy_interface_t interface)
   948	{
   949		int rc;
   950	
   951		if (!dev)
 > 952			return ERR_PTR(-EINVAL);
   953	
   954		rc = phy_attach_direct(dev, phydev, phydev->dev_flags, interface);
   955		if (rc)
   956			return rc;
   957	
   958		phy_prepare_link(phydev, handler);
   959		if (phy_interrupt_is_valid(phydev))
   960			phy_request_interrupt(phydev);
   961	
   962		return 0;
   963	}
   964	EXPORT_SYMBOL(phy_connect_direct);
   965	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation