netdev - Re: [PATCH net-next 0/6] add TFO backup key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3064376-6bc9-fa04-6ca8-a0c8e982ee03@akamai.com>
Date:   Tue, 28 May 2019 10:36:37 -0400
From:   Jason Baron <jbaron@...mai.com>
To:     Yuchung Cheng <ycheng@...gle.com>,
        David Miller <davem@...emloft.net>
Cc:     Eric Dumazet <edumazet@...gle.com>, ilubashe@...mai.com,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/6] add TFO backup key

On 5/24/19 7:17 PM, Yuchung Cheng wrote:
> On Thu, May 23, 2019 at 4:31 PM Yuchung Cheng <ycheng@...gle.com> wrote:
>>
>> On Thu, May 23, 2019 at 12:14 PM David Miller <davem@...emloft.net> wrote:
>>>
>>> From: Jason Baron <jbaron@...mai.com>
>>> Date: Wed, 22 May 2019 16:39:32 -0400
>>>
>>>> Christoph, Igor, and I have worked on an API that facilitates TFO key
>>>> rotation. This is a follow up to the series that Christoph previously
>>>> posted, with an API that meets both of our use-cases. Here's a
>>>> link to the previous work:
>>>> https://patchwork.ozlabs.org/cover/1013753/
>>>
>>> I have no objections.
>>>
>>> Yuchung and Eric, please review.
>>>
>>> And anyways there will be another spin of this to fix the typo in the documentation
>>> patch #5.
>> patch set looks fine. I am testing them w/ our internal TFO packetdrill tests.
>>>
>>> Thanks.
> The patch series pass the packetdrill TFO tests :-) It'd be great to
> support of TCP_FASTOPEN_KEY sock opt additionally.
> 
> Acked-by: Yuchung Cheng <ycheng@...gle.com>
>

Thanks for testing. So patch #3 adds support for the backup key to
TCP_FASTOPEN_KEY sock opt for both set/get. Is this what you are
referring to or something else?

Thanks,

-Jason