netdev - Re: [PATCH 03/11] net: phy: Check against net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190528155149.GP18059@lunn.ch>
Date:   Tue, 28 May 2019 17:51:49 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     linux@...linux.org.uk, f.fainelli@...il.com, hkallweit1@...il.com,
        maxime.chevallier@...tlin.com, olteanv@...il.com,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 03/11] net: phy: Check against net_device being NULL

On Tue, May 28, 2019 at 12:21:59AM +0300, Ioana Ciornei wrote:
> In general, we don't want MAC drivers calling phy_attach_direct with the
> net_device being NULL. Add checks against this in all the functions
> calling it: phy_attach() and phy_connect_direct().
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> Suggested-by: Andrew Lunn <andrew@...n.ch>

I should actually say, once you fix the sparse warnings, you can add:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew