lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPhsuW7H=w_UMyu5Q5p5+MGogkQ7+7X7sS=vJTiR=+JJy0KuTg@mail.gmail.com> Date: Tue, 28 May 2019 09:45:14 -0700 From: Song Liu <liu.song.a23@...il.com> To: Alakesh Haloi <alakesh.haloi@...il.com> Cc: Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Stanislav Fomichev <sdf@...gle.com>, linux-kselftest@...r.kernel.org, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] selftests: bpf: fix compiler warning On Thu, May 23, 2019 at 5:31 PM Alakesh Haloi <alakesh.haloi@...il.com> wrote: > > Add missing header file following compiler warning > > prog_tests/flow_dissector.c: In function ‘tx_tap’: > prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration] > return writev(fd, iov, ARRAY_SIZE(iov)); > ^~~~~~ > write > > Signed-off-by: Alakesh Haloi <alakesh.haloi@...il.com> The patch looks good. Please add a "Fixes" tag, so the fix can be back ported properly. Also, please specify which tree the patch should be applied with [PATCH bpf] or [PATCH bpf-next]. Thanks, Song > --- > tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > index fbd1d88a6095..c938283ac232 100644 > --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > @@ -3,6 +3,7 @@ > #include <error.h> > #include <linux/if.h> > #include <linux/if_tun.h> > +#include <sys/uio.h> > > #define CHECK_FLOW_KEYS(desc, got, expected) \ > CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \ > -- > 2.17.1 >
Powered by blists - more mailing lists