netdev - Re: [PATCH net-next] r8169: remove 1000/Half from supported modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d22f35c-4f1c-48e8-b32d-dcbed59d3dd2@gmail.com>
Date:   Tue, 28 May 2019 20:02:08 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: remove 1000/Half from supported modes

On 28.05.2019 19:40, Florian Fainelli wrote:
> On 5/28/19 9:43 AM, Heiner Kallweit wrote:
>> MAC on the GBit versions supports 1000/Full only, however the PHY
>> partially claims to support 1000/Half. So let's explicitly remove
>> this mode.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> Don't you want a Fixes: tag for that?
> 
I'm not aware of any problem caused by that. And according to what
I've read 1000/Half has been specified but never really been used.
So it should be sufficient to treat this as an improvement.

>> ---
>>  drivers/net/ethernet/realtek/r8169.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index 61e7eef5e..0239a3de2 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -6397,7 +6397,10 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
>>  	if (ret)
>>  		return ret;
>>  
>> -	if (!tp->supports_gmii)
>> +	if (tp->supports_gmii)
>> +		phy_remove_link_mode(phydev,
>> +				     ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
>> +	else
>>  		phy_set_max_speed(phydev, SPEED_100);
>>  
>>  	phy_support_asym_pause(phydev);
>>
> 
>