lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <482063b4-8c0c-7944-6550-a73d0d9492be@gmail.com> Date: Tue, 28 May 2019 11:21:52 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Marek Vasut <marex@...x.de>, netdev@...r.kernel.org Cc: Andrew Lunn <andrew@...n.ch>, Guenter Roeck <linux@...ck-us.net>, Heiner Kallweit <hkallweit1@...il.com>, Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org Subject: Re: [PATCH] net: phy: tja11xx: Add IRQ support to the driver On 5/28/19 11:16 AM, Marek Vasut wrote: > Add support for handling the TJA11xx PHY IRQ signal. > > Signed-off-by: Marek Vasut <marex@...x.de> > Cc: Andrew Lunn <andrew@...n.ch> > Cc: Florian Fainelli <f.fainelli@...il.com> > Cc: Guenter Roeck <linux@...ck-us.net> > Cc: Heiner Kallweit <hkallweit1@...il.com> > Cc: Jean Delvare <jdelvare@...e.com> > Cc: linux-hwmon@...r.kernel.org > --- > drivers/net/phy/nxp-tja11xx.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja11xx.c > index b705d0bd798b..0be9fe9a9604 100644 > --- a/drivers/net/phy/nxp-tja11xx.c > +++ b/drivers/net/phy/nxp-tja11xx.c > @@ -40,6 +40,8 @@ > #define MII_INTSRC_TEMP_ERR BIT(1) > #define MII_INTSRC_UV_ERR BIT(3) > > +#define MII_INTEN 22 > + > #define MII_COMMSTAT 23 > #define MII_COMMSTAT_LINK_UP BIT(15) > > @@ -239,6 +241,30 @@ static int tja11xx_read_status(struct phy_device *phydev) > return 0; > } > > +static int tja11xx_config_intr(struct phy_device *phydev) > +{ > + int ret; > + > + if (phydev->interrupts == PHY_INTERRUPT_ENABLED) > + ret = phy_write(phydev, MII_INTEN, 0xcfef); It would be nice to define the shifts and masks being used here. Other than that, this looks good. -- Florian
Powered by blists - more mailing lists