netdev - Re: [PATCH] net: phy: tja11xx: Add IRQ support to the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb1f305b-0ad9-7923-b4eb-24868cce1f48@denx.de>
Date:   Tue, 28 May 2019 21:14:50 +0200
From:   Marek Vasut <marex@...x.de>
To:     Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] net: phy: tja11xx: Add IRQ support to the driver

On 5/28/19 8:29 PM, Heiner Kallweit wrote:
> On 28.05.2019 20:16, Marek Vasut wrote:
>> Add support for handling the TJA11xx PHY IRQ signal.
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
>> Cc: Andrew Lunn <andrew@...n.ch>
>> Cc: Florian Fainelli <f.fainelli@...il.com>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: Heiner Kallweit <hkallweit1@...il.com>
>> Cc: Jean Delvare <jdelvare@...e.com>
>> Cc: linux-hwmon@...r.kernel.org
>> ---
>>  drivers/net/phy/nxp-tja11xx.c | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>
>> diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja11xx.c
>> index b705d0bd798b..0be9fe9a9604 100644
>> --- a/drivers/net/phy/nxp-tja11xx.c
>> +++ b/drivers/net/phy/nxp-tja11xx.c
>> @@ -40,6 +40,8 @@
>>  #define MII_INTSRC_TEMP_ERR		BIT(1)
>>  #define MII_INTSRC_UV_ERR		BIT(3)
>>  
>> +#define MII_INTEN			22
>> +
>>  #define MII_COMMSTAT			23
>>  #define MII_COMMSTAT_LINK_UP		BIT(15)
>>  
>> @@ -239,6 +241,30 @@ static int tja11xx_read_status(struct phy_device *phydev)
>>  	return 0;
>>  }
>>  
>> +static int tja11xx_config_intr(struct phy_device *phydev)
>> +{
>> +	int ret;
>> +
>> +	if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
>> +		ret = phy_write(phydev, MII_INTEN, 0xcfef);
> 
> As Florian commented already, such magic numbers are not nice.
> Better add a constant for each bit representing an interrupt
> source. Please note that phylib is interested in the link
> change event only. Therefore typically only one bit is set.

With this PHY, it seems all of those bits have impact on the link.

>> +	else
>> +		ret = phy_write(phydev, MII_INTEN, 0);
>> +
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret = phy_read(phydev, MII_INTSRC);
>> +
> 
> This IRQ ACK can be removed. It's done by phylib, see
> phy_enable_interrupts().
OK

-- 
Best regards,
Marek Vasut