netdev - [PATCH] net: mvpp2: setup link irqs for ports with in-band-status phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d35f93599eab47ea78e9d42ce18673733611fbd8.camel@declera.com>
Date:   Tue, 28 May 2019 23:03:00 +0300
From:   Yanko Kaneti <yaneti@...lera.com>
To:     netdev <netdev@...r.kernel.org>
Subject: [PATCH] net: mvpp2: setup link irqs for ports with in-band-status
 phylink

Hello

This might be misguided but it seems to fix link status on my mcbin-
singleshot SFP+ ports

-Yanko

-- >8 --

MACCHIATObin Single-shot uses the direct-to-MAC SFP+ ports setup
which phylink supports in in-band-status mode. Don't assume
phylink means external phy and connect the link irqs.

Signed-off-by: Yanko Kaneti <yaneti@...lera.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index d38952eb7aa9..2f6acc38087c 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -3447,7 +3447,7 @@ static int mvpp2_open(struct net_device *dev)
 		valid = true;
 	}
 
-	if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) {
+	if (priv->hw_version == MVPP22 && port->link_irq && !port->has_phy) {
 		err = request_irq(port->link_irq, mvpp2_link_status_isr, 0,
 				  dev->name, port);
 		if (err) {
--