netdev - Re: [PATCH V2] net: phy: tja11xx: Add IRQ support to the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe6c4f2f-812d-61b8-3ffb-7ed7dd89d151@denx.de>
Date:   Tue, 28 May 2019 23:33:33 +0200
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH V2] net: phy: tja11xx: Add IRQ support to the driver

On 5/28/19 11:22 PM, Andrew Lunn wrote:
>> The link detection on the TJA1100 (not TJA1101) seems unstable at best,
>> so I better use all the interrupt sources to nudge the PHY subsystem and
>> have it check the link change.
> 
> Then it sounds like you should just ignore interrupts and stay will
> polling for the TJA1100.

Polling for the link status change is slow(er) than the IRQ driven
operation, so I would much rather use the interrupts.

-- 
Best regards,
Marek Vasut