lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 27 May 2019 22:28:55 -0700
From:   Richard Cochran <>
To:     Andrew Lunn <>
Cc:, David Miller <>,,
        Florian Fainelli <>,
        Jacob Keller <>,
        Mark Rutland <>,
        Miroslav Lichvar <>,
        Rob Herring <>,
        Willem de Bruijn <>
Subject: Re: [PATCH V3 net-next 6/6] ptp: Add a driver for InES time stamping
 IP core.

On Wed, May 22, 2019 at 03:42:20AM +0200, Andrew Lunn wrote:
> I don't know about the PTP subsystem, but in general, forward
> declarations are frowned upon, and it is generally requested to
> reorder the functions to remove them.

I am not aware of any general coding style rule or even defacto
practice in this area, but there is a method to this driver.  The
functions are in alphabetical order.  This makes it easier to find
your way around the driver.


Powered by blists - more mailing lists