netdev - Re: [PATCH net v2] af_key: fix leaks in key_pol_get_resp and dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190528074512.GE14601@gauss3.secunet.de>
Date:   Tue, 28 May 2019 09:45:12 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Jeremy Sowden <jeremy@...zel.net>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <syzbot+4f0529365f7f2208d9f0@...kaller.appspotmail.com>
Subject: Re: [PATCH net v2] af_key: fix leaks in key_pol_get_resp and dump_sp.

On Sat, May 25, 2019 at 07:09:35PM +0100, Jeremy Sowden wrote:
> In both functions, if pfkey_xfrm_policy2msg failed we leaked the newly
> allocated sk_buff.  Free it on error.
> 
> Fixes: 55569ce256ce ("Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.")
> Reported-by: syzbot+4f0529365f7f2208d9f0@...kaller.appspotmail.com
> Signed-off-by: Jeremy Sowden <jeremy@...zel.net>

Applied, thanks Jeremy!