netdev - use of uninitialized value in mv88e6185_port_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9dd8c118-c991-537b-acf2-2a07a07eb2b8@prevas.dk>
Date:   Tue, 28 May 2019 08:13:50 +0000
From:   Rasmus Villemoes <rasmus.villemoes@...vas.dk>
To:     Network Development <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: use of uninitialized value in mv88e6185_port_link_state

Hi,

mv88e6185_port_link_state starts by inspecting state->interface. AFAICT,
it can be called from two places:

mv88e6xxx_link_state <-
dsa_slave_phylink_mac_link_state <-
phylink_get_mac_state

which does initialize state->interface before passing it, but also from
mv88e6xxx_port_setup_mac, which passes an uninitialized stack variable.
This seems like a bug, but I don't know what the proper fix would be.
Simply initialize state.interface to mode?

Rasmus