netdev - Re: [PATCH net-next] team: add ethtool get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190528090823.GB2699@nanopsycho>
Date:   Tue, 28 May 2019 11:08:23 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] team: add ethtool get_link_ksettings

Mon, May 27, 2019 at 05:31:10AM CEST, liuhangbin@...il.com wrote:
>Like bond, add ethtool get_link_ksettings to show the total speed.
>
>Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
>---
> drivers/net/team/team.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index 2106045b3e16..5e892ee4c006 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -2058,9 +2058,34 @@ static void team_ethtool_get_drvinfo(struct net_device *dev,
> 	strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));
> }
> 
>+static int team_ethtool_get_link_ksettings(struct net_device *dev,
>+					   struct ethtool_link_ksettings *cmd)
>+{
>+	struct team *team= netdev_priv(dev);
>+	unsigned long speed = 0;
>+	struct team_port *port;
>+
>+	cmd->base.duplex = DUPLEX_UNKNOWN;
>+	cmd->base.port = PORT_OTHER;
>+
>+	list_for_each_entry(port, &team->port_list, list) {
>+		if (team_port_txable(port)) {
>+			if (port->state.speed != SPEED_UNKNOWN)
>+				speed += port->state.speed;
>+			if (cmd->base.duplex == DUPLEX_UNKNOWN &&
>+			    port->state.duplex != DUPLEX_UNKNOWN)
>+				cmd->base.duplex = port->state.duplex;

What is exactly the point of this patch? Why do you need such
information. This is hw-related info. If you simply sum-up all txable
ports, the value is always highly misleading.

For example for hash-based port selection with 2 100Mbit ports,
you will get 200Mbit, but it is not true. It is up to the traffic and
hash function what is the actual TX speed you can get.
On the RX side, this is even more misleading as the actual speed depends
on the other side of the wire.


>+		}
>+	}
>+	cmd->base.speed = speed ? : SPEED_UNKNOWN;
>+
>+	return 0;
>+}
>+
> static const struct ethtool_ops team_ethtool_ops = {
> 	.get_drvinfo		= team_ethtool_get_drvinfo,
> 	.get_link		= ethtool_op_get_link,
>+	.get_link_ksettings	= team_ethtool_get_link_ksettings,
> };
> 
> /***********************
>-- 
>2.19.2
>