netdev - Re: [PATCH v2 net-next 06/11] net: phylink: Add struct phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190529092845.4bc7439f@bootlin.com>
Date:   Wed, 29 May 2019 09:28:45 +0200
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     linux@...linux.org.uk, f.fainelli@...il.com, andrew@...n.ch,
        hkallweit1@...il.com, olteanv@...il.com,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 06/11] net: phylink: Add struct
 phylink_config to PHYLINK API

Hello Ioana,

On Tue, 28 May 2019 20:38:12 +0300
Ioana Ciornei <ioana.ciornei@....com> wrote:

>The phylink_config structure will encapsulate a pointer to a struct
>device and the operation type requested for this instance of PHYLINK.
>This patch does not make any functional changes, it just transitions the
>PHYLINK internals and all its users to the new API.
>
>A pointer to a phylink_config structure will be passed to
>phylink_create() instead of the net_device directly. Also, the same
>phylink_config pointer will be passed back to all phylink_mac_ops
>callbacks instead of the net_device. Using this mechanism, a PHYLINK
>user can get the original net_device using a structure such as
>'to_net_dev(config->dev)' or directly the structure containing the
>phylink_config using a container_of call.

I see that you mixed both to_net_dev and container_of uses in mvpp2, is
there a reason for that ?

Other than that, for the mvpp2 part,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Thanks,

Maxime