netdev - Re: [PATCH net-next 3/7] afs: switch to in_dev_for_each_ifa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 May 2019 14:49:39 +0100
From:   David Howells <dhowells@...hat.com>
To:     Florian Westphal <fw@...len.de>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        linux-afs@...ts.infradead.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/7] afs: switch to in_dev_for_each_ifa_rcu

Florian Westphal <fw@...len.de> wrote:

> The in_dev_for_each_ifa_rcu helper gets used so sparse won't
> complain when we add the proper __rcu annotation to the ifa_list
> member in struct in_device later.
> 
> While doing this I realized the helper only has one call site,
> so move it to where its needed.
> 
> This then revealed that we allocate a temporary buffer needlessly
> and pass an always-false bool argument.
> 
> So fold this into the calling function and fill dst buffer directly.
> 
> Compile tested only.

Actually, whilst thanks are due for doing the work - it looks nicer now - I'm
told that there's not really any point populating the list.  Current OpenAFS
ignores it, as does AuriStor - and IBM AFS 3.6 will do the right thing.

The list is actually useless as it's the client's view of the world, not the
servers, so if there's any NAT in the way its contents are invalid.  Further,
it doesn't support IPv6 addresses.

On that basis, feel free to make it an empty list and remove all the interface
enumeration.

David