netdev - Re: [PATCH bpf-next] selftests/bpf: fix compilation error for flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eafd0738-c78d-ac5e-ebd2-1f70936fc8dd@iogearbox.net>
Date:   Wed, 29 May 2019 16:06:52 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alan Maguire <alan.maguire@...cle.com>, ast@...nel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Cc:     kafai@...com, songliubraving@...com, yhs@...com,
        davem@...emloft.net, nicolas.dichtel@...nd.com,
        ktkhai@...tuozzo.com
Subject: Re: [PATCH bpf-next] selftests/bpf: fix compilation error for
 flow_dissector.c

On 05/29/2019 11:48 AM, Alan Maguire wrote:
> When building the tools/testing/selftest/bpf subdirectory,
> (running both a local directory "make" and a
> "make -C tools/testing/selftests/bpf") I keep hitting the
> following compilation error:
> 
> prog_tests/flow_dissector.c: In function ‘create_tap’:
> prog_tests/flow_dissector.c:150:38: error: ‘IFF_NAPI’ undeclared (first
> use in this function)
>    .ifr_flags = IFF_TAP | IFF_NO_PI | IFF_NAPI | IFF_NAPI_FRAGS,
>                                       ^
> prog_tests/flow_dissector.c:150:38: note: each undeclared identifier is
> reported only once for each function it appears in
> prog_tests/flow_dissector.c:150:49: error: ‘IFF_NAPI_FRAGS’ undeclared
> 
> Adding include/uapi/linux/if_tun.h to tools/include/uapi/linux
> resolves the problem and ensures the compilation of the file
> does not depend on having up-to-date kernel headers locally.
> 
> Signed-off-by: Alan Maguire <alan.maguire@...cle.com>

Applied, thanks!