netdev - Re: [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 May 2019 10:43:45 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in
 rta_nest

On Wed, 29 May 2019 20:17:38 -0700
David Ahern <dsahern@...nel.org> wrote:

> From: David Ahern <dsahern@...il.com>
> 
> Kernel now requires NLA_F_NESTED to be set on new nested
> attributes. Set NLA_F_NESTED in rta_nest.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
>  lib/libnetlink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> index 0d48a3d43cf0..6ae51a9dba14 100644
> --- a/lib/libnetlink.c
> +++ b/lib/libnetlink.c
> @@ -1336,6 +1336,7 @@ struct rtattr *rta_nest(struct rtattr *rta, int maxlen, int type)
>  	struct rtattr *nest = RTA_TAIL(rta);
>  
>  	rta_addattr_l(rta, maxlen, type, NULL, 0);
> +	nest->rta_type |= NLA_F_NESTED;
>  
>  	return nest;
>  }

I assume older kernels ignore the attribute?

Also, how is this opt-in for running iproute2-next on old kernels?