netdev - Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190530.124141.171150800649105078.davem@davemloft.net>
Date:   Thu, 30 May 2019 12:41:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sameehj@...zon.com
Cc:     netdev@...r.kernel.org, akiyano@...zon.com, dwmw@...zon.com,
        zorik@...zon.com, matua@...zon.com, saeedb@...zon.com,
        msw@...zon.com, aliguori@...zon.com, nafea@...zon.com,
        gtzalik@...zon.com, netanel@...zon.com, alisaidi@...zon.com,
        benh@...zon.com
Subject: Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra
 properties retrieval via get_priv_flags

From: <sameehj@...zon.com>
Date: Wed, 29 May 2019 12:49:55 +0300

> @@ -560,6 +564,14 @@ struct ena_admin_set_feature_mtu_desc {
>  	u32 mtu;
>  };
>  
> +struct ena_admin_get_extra_properties_strings_desc {
> +	u32 count;
> +};
> +
> +struct ena_admin_get_extra_properties_flags_desc {
> +	u32 flags;
> +};

These single entry structures are a big overkill.  If anything just do one
which is like "ena_value_desc" and has that "u32 val;"