netdev - Re: [PATCH v2 net 0/2] Fixes for DSA tagging using 802.1Q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190530.144728.2263518019034067506.davem@davemloft.net>
Date:   Thu, 30 May 2019 14:47:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        ioana.ciornei@....com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net 0/2] Fixes for DSA tagging using 802.1Q

From: Vladimir Oltean <olteanv@...il.com>
Date: Thu, 30 May 2019 00:42:29 +0300

> During the prototyping for the "Decoupling PHYLINK from struct
> net_device" patchset, the CPU port of the sja1105 driver was moved to a
> different spot.  This uncovered an issue in the tag_8021q DSA code,
> which used to work by mistake - the CPU port was the last hardware port
> numerically, and this was masking an ordering issue which is very likely
> to be seen in other drivers that make use of 802.1Q tags.
> 
> A question was also raised whether the VID numbers bear any meaning, and
> the conclusion was that they don't, at least not in an absolute sense.
> The second patch defines bit fields inside the DSA 802.1Q VID so that
> tcpdump can decode it unambiguously (although the meaning is now clear
> even by visual inspection).

Series applied.