netdev - Re: [PATCH net] net: don't clear sock->sk early to avoid trouble in strparser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190530.145700.2173544714958397302.davem@davemloft.net>
Date:   Thu, 30 May 2019 14:57:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        edumazet@...gle.com, alexei.starovoitov@...il.com,
        david.beckett@...ronome.com, dirk.vandermerwe@...ronome.com
Subject: Re: [PATCH net] net: don't clear sock->sk early to avoid trouble
 in strparser

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 29 May 2019 16:33:23 -0700

> af_inet sets sock->sk to NULL which trips strparser over:
 ...
> To avoid this issue set sock->sk after sk_prot->close.
> My grepping and testing did not discover any code which
> would depend on the current behaviour.
> 
> Fixes: c46234ebb4d1 ("tls: RX path for ktls")
> Reported-by: David Beckett <david.beckett@...ronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> ---
> We probably want to hold off on stable with this one :)

Ok, applied.  Will hold off on -stable :)

I only worry about sk visibility after whatever close does.