netdev - Re: [PATCH net] net: mvpp2: fix bad MVPP2_TXQ_SCHED_TOKEN_CNTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190530.143150.592829291503380971.davem@davemloft.net>
Date:   Thu, 30 May 2019 14:31:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     antoine.tenart@...tlin.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, maxime.chevallier@...tlin.com,
        gregory.clement@...tlin.com, miquel.raynal@...tlin.com,
        nadavh@...vell.com, stefanc@...vell.com, mw@...ihalf.com
Subject: Re: [PATCH net] net: mvpp2: fix bad MVPP2_TXQ_SCHED_TOKEN_CNTR_REG
 queue value

From: Antoine Tenart <antoine.tenart@...tlin.com>
Date: Wed, 29 May 2019 15:59:48 +0200

> MVPP2_TXQ_SCHED_TOKEN_CNTR_REG() expects the logical queue id but
> the current code is passing the global tx queue offset, so it ends
> up writing to unknown registers (between 0x8280 and 0x82fc, which
> seemed to be unused by the hardware). This fixes the issue by using
> the logical queue id instead.
> 
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Applied and queued up for -stable.