netdev - Re: [PATCH net-next 1/6] seg6: Fix TLV definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDqMepF7DrF3YunbHKid_=SvD1_7QjQS-BddYs+O7sL_EdPjQ@mail.gmail.com>
Date:   Thu, 30 May 2019 16:17:50 -0700
From:   Tom Herbert <tom@...ntonium.net>
To:     David Miller <davem@...emloft.net>
Cc:     Tom Herbert <tom@...bertland.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        dlebrun@...gle.com
Subject: Re: [PATCH net-next 1/6] seg6: Fix TLV definitions

On Thu, May 30, 2019 at 3:18 PM David Miller <davem@...emloft.net> wrote:
>
> From: Tom Herbert <tom@...bertland.com>
> Date: Thu, 30 May 2019 14:50:16 -0700
>
> > TLV constants are defined for PAD1, PADN, and HMAC (the three defined in
> > draft-ietf-6man-segment-routing-header-19). The other TLV are unused and
> > not correct so they are removed.
>
> Removing macros will break userland compilation, you cannot do this.

Is it okay to change the value of a uapi macro?

Thanks,
Tom