netdev - Re: [PATCH net-next] cxgb4/libcxgb/cxgb4i/cxgbit: enable eDRAM page pods for iSCSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1lfyozp90.fsf@oracle.com>
Date:   Wed, 29 May 2019 21:48:27 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Varun Prakash <varun@...lsio.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        target-devel@...r.kernel.org, linux-scsi@...r.kernel.org,
        dt@...lsio.com, indranil@...lsio.com, ganji.aravind@...lsio.com
Subject: Re: [PATCH net-next] cxgb4/libcxgb/cxgb4i/cxgbit: enable eDRAM page pods for iSCSI


Varun,

> Page pods are used for direct data placement, this patch enables eDRAM
> page pods if firmware supports this feature.

No objections to the SCSI bits.

> @@ -394,6 +398,26 @@ int cxgbi_ppm_init(void **ppm_pp, struct net_device *ndev,
>  	unsigned int pool_index_max = 0;
>  	unsigned int alloc_sz;
>  	unsigned int ppod_bmap_size;
> +	unsigned int ppmax;
> +
> +	if (!iscsi_edram_start)
> +		iscsi_edram_size = 0;
> +
> +	if (iscsi_edram_size &&
> +	    ((iscsi_edram_start + iscsi_edram_size) != start)) {
> +		pr_err("iscsi ppod region not contigious: EDRAM start 0x%x "

contiguous

-- 
Martin K. Petersen	Oracle Linux Engineering