netdev - RE: [PATCH net-next 3/7] dpaa2-eth: Remove preempt_disable() from seed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 May 2019 09:24:46 +0000
From:   Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH net-next 3/7] dpaa2-eth: Remove preempt_disable() from
 seed_pool()

> -----Original Message-----
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Sent: Thursday, May 30, 2019 1:15 AM
> To: netdev@...r.kernel.org
> Cc: tglx@...utronix.de; David S. Miller <davem@...emloft.net>; Sebastian
> Andrzej Siewior <bigeasy@...utronix.de>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@....com>
> Subject: [PATCH net-next 3/7] dpaa2-eth: Remove preempt_disable() from
> seed_pool()
> 
> According to the comment, the preempt_disable() statement is required
> due to synchronisation in napi_alloc_frag(). The awful truth is that
> local_bh_disable() is required because otherwise the NAPI poll callback
> can be invoked while the open function setup buffers. This isn't
> unlikely since the dpaa2 provides multiple devices.
> 
> The usage of napi_alloc_frag() has been removed in commit
> 
>  27c874867c4e9 ("dpaa2-eth: Use a single page per Rx buffer")
> 
> which means that the comment is not accurate and the preempt_disable()
> statement is not required.
> 
> Remove the outdated comment and the no longer required
> preempt_disable().
> 
> Cc: Ioana Radulescu <ruxandra.radulescu@....com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Acked-by: Ioana Radulescu <ruxandra.radulescu@....com>

Thanks,
Ioana