netdev - RE: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b39873d56509459a956ff41458b5ca19@EX13D22EUA004.ant.amazon.com>
Date:   Thu, 30 May 2019 12:21:35 +0000
From:   "Kiyanovski, Arthur" <akiyano@...zon.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "Jubran, Samih" <sameehj@...zon.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>
Subject: RE: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties
 retrieval via get_priv_flags

> -----Original Message-----
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Sent: Thursday, May 30, 2019 1:10 AM
> To: Jubran, Samih <sameehj@...zon.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Kiyanovski, Arthur
> <akiyano@...zon.com>; Woodhouse, David <dwmw@...zon.co.uk>;
> Machulsky, Zorik <zorik@...zon.com>; Matushevsky, Alexander
> <matua@...zon.com>; Bshara, Saeed <saeedb@...zon.com>; Wilson, Matt
> <msw@...zon.com>; Liguori, Anthony <aliguori@...zon.com>; Bshara,
> Nafea <nafea@...zon.com>; Tzalik, Guy <gtzalik@...zon.com>; Belgazal,
> Netanel <netanel@...zon.com>; Saidi, Ali <alisaidi@...zon.com>;
> Herrenschmidt, Benjamin <benh@...zon.com>
> Subject: Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties
> retrieval via get_priv_flags
> 
> On Wed, 29 May 2019 12:49:55 +0300, sameehj@...zon.com wrote:
> > From: Arthur Kiyanovski <akiyano@...zon.com>
> >
> > This commit adds a mechanism for exposing different driver properties
> > via ethtool's priv_flags.
> >
> > In this commit we:
> >
> > Add commands, structs and defines necessary for handling extra
> > properties
> >
> > Add functions for:
> > Allocation/destruction of a buffer for extra properties strings.
> > Retreival of extra properties strings and flags from the network device.
> >
> > Handle the allocation of a buffer for extra properties strings.
> >
> > * Initialize buffer with extra properties strings from the
> >   network device at driver startup.
> >
> > Use ethtool's get_priv_flags to expose extra properties of the ENA
> > device
> >
> > Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>
> > Signed-off-by: Sameeh Jubran <sameehj@...zon.com>
> 
> This commit DMAs in the string set blindly from the FW and exposes it to user
> space, without any interpretation by the driver, correct?
> Making the driver a mere proxy for the FW.  I think it should be clearly
> mentioned in the commit message, to make sure we know what what we are
> accepting here.  I'm always a little uncomfortable with such changes :) (I'm not
> actually sure there is a precedent for this).

Ack. We will update the commit message in the next version of the patch with more information.