netdev - Re: [PATCH net-next] cxgb4: Set initial IRQ affinity hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 May 2019 19:05:52 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nirranjan Kirubaharan <nirranjan@...lsio.com>
Cc:     kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
        vishal@...lsio.com, dt@...lsio.com, indranil@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: Set initial IRQ affinity hints

Hi Nirranjan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Nirranjan-Kirubaharan/cxgb4-Set-initial-IRQ-affinity-hints/20190531-180720
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'cxgb4_set_msix_aff':
>> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:710:26: error: passing argument 1 of 'zalloc_cpumask_var' from incompatible pointer type [-Werror=incompatible-pointer-types]
     if (!zalloc_cpumask_var(&aff_mask, GFP_KERNEL)) {
                             ^
   In file included from include/linux/rcupdate.h:31:0,
                    from include/linux/rculist.h:11,
                    from include/linux/dcache.h:7,
                    from include/linux/fs.h:8,
                    from include/linux/debugfs.h:15,
                    from drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:40:
   include/linux/cpumask.h:737:20: note: expected 'struct cpumask (*)[1]' but argument is of type 'struct cpumask **'
    static inline bool zalloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
                       ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/zalloc_cpumask_var +710 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

   704	
   705	int cxgb4_set_msix_aff(struct adapter *adap, unsigned short vec,
   706			       cpumask_var_t aff_mask, int idx)
   707	{
   708		int rv;
   709	
 > 710		if (!zalloc_cpumask_var(&aff_mask, GFP_KERNEL)) {
   711			dev_err(adap->pdev_dev, "alloc_cpumask_var failed\n");
   712			return -ENOMEM;
   713		}
   714	
   715		cpumask_set_cpu(cpumask_local_spread(idx, dev_to_node(adap->pdev_dev)),
   716				aff_mask);
   717	
   718		rv = irq_set_affinity_hint(vec, aff_mask);
   719		if (rv)
   720			dev_warn(adap->pdev_dev,
   721				 "irq_set_affinity_hint %u failed %d\n",
   722				 vec, rv);
   723	
   724		return 0;
   725	}
   726	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (58663 bytes)