netdev - Re: [PATCH V4 net-next 2/6] net: Introduce a new MII time stamping interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201905312313.WzZD52Tz%lkp@intel.com>
Date:   Fri, 31 May 2019 23:05:29 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>, devicetree@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Mark Rutland <mark.rutland@....com>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH V4 net-next 2/6] net: Introduce a new MII time stamping
 interface.

Hi Richard,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Richard-Cochran/Peer-to-Peer-One-Step-time-stamping/20190531-213601
config: s390-debug_defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/macvlan.c: In function 'macvlan_ethtool_get_ts_info':
>> drivers/net/macvlan.c:1059:42: error: 'struct phy_driver' has no member named 'ts_info'
     if (phydev && phydev->drv && phydev->drv->ts_info) {
                                             ^~
   drivers/net/macvlan.c:1060:22: error: 'struct phy_driver' has no member named 'ts_info'
       return phydev->drv->ts_info(phydev, info);
                         ^~

vim +1059 drivers/net/macvlan.c

9edb8bb6 Stephen Hemminger 2008-10-29  1051  
254c0a2b Hangbin Liu       2019-03-20  1052  static int macvlan_ethtool_get_ts_info(struct net_device *dev,
254c0a2b Hangbin Liu       2019-03-20  1053  				       struct ethtool_ts_info *info)
254c0a2b Hangbin Liu       2019-03-20  1054  {
254c0a2b Hangbin Liu       2019-03-20  1055  	struct net_device *real_dev = macvlan_dev_real_dev(dev);
254c0a2b Hangbin Liu       2019-03-20  1056  	const struct ethtool_ops *ops = real_dev->ethtool_ops;
254c0a2b Hangbin Liu       2019-03-20  1057  	struct phy_device *phydev = real_dev->phydev;
254c0a2b Hangbin Liu       2019-03-20  1058  
254c0a2b Hangbin Liu       2019-03-20 @1059  	if (phydev && phydev->drv && phydev->drv->ts_info) {
254c0a2b Hangbin Liu       2019-03-20  1060  		 return phydev->drv->ts_info(phydev, info);
254c0a2b Hangbin Liu       2019-03-20  1061  	} else if (ops->get_ts_info) {
254c0a2b Hangbin Liu       2019-03-20  1062  		return ops->get_ts_info(real_dev, info);
254c0a2b Hangbin Liu       2019-03-20  1063  	} else {
254c0a2b Hangbin Liu       2019-03-20  1064  		info->so_timestamping = SOF_TIMESTAMPING_RX_SOFTWARE |
254c0a2b Hangbin Liu       2019-03-20  1065  			SOF_TIMESTAMPING_SOFTWARE;
254c0a2b Hangbin Liu       2019-03-20  1066  		info->phc_index = -1;
254c0a2b Hangbin Liu       2019-03-20  1067  	}
254c0a2b Hangbin Liu       2019-03-20  1068  
254c0a2b Hangbin Liu       2019-03-20  1069  	return 0;
254c0a2b Hangbin Liu       2019-03-20  1070  }
254c0a2b Hangbin Liu       2019-03-20  1071  

:::::: The code at line 1059 was first introduced by commit
:::::: 254c0a2bfedb9e1baf38bd82ca86494d4bc1e0cb macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

:::::: TO: Hangbin Liu <liuhangbin@...il.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (20391 bytes)