netdev - Re: [PATCH net 1/1] net: dsa: sja1105: Don't store frame type in skb->cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190531.142756.672384459952948359.davem@davemloft.net>
Date:   Fri, 31 May 2019 14:27:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        netdev@...r.kernel.org
Subject: Re: [PATCH net 1/1] net: dsa: sja1105: Don't store frame type in
 skb->cb

From: Vladimir Oltean <olteanv@...il.com>
Date: Thu, 30 May 2019 00:51:26 +0300

> Due to a confusion I thought that eth_type_trans() was called by the
> network stack whereas it can actually be called by network drivers to
> figure out the skb protocol and next packet_type handlers.
> 
> In light of the above, it is not safe to store the frame type from the
> DSA tagger's .filter callback (first entry point on RX path), since GRO
> is yet to be invoked on the received traffic.  Hence it is very likely
> that the skb->cb will actually get overwritten between eth_type_trans()
> and the actual DSA packet_type handler.
> 
> Of course, what this patch fixes is the actual overwriting of the
> SJA1105_SKB_CB(skb)->type field from the GRO layer, which made all
> frames be seen as SJA1105_FRAME_TYPE_NORMAL (0).
> 
> Fixes: 227d07a07ef1 ("net: dsa: sja1105: Add support for traffic through standalone ports")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied, thanks.