netdev - Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ace2225d-f0fe-03b3-12ee-b442265211dd@gmail.com>
Date:   Fri, 31 May 2019 15:38:19 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, alexei.starovoitov@...il.com
Cc:     dsahern@...nel.org, netdev@...r.kernel.org, idosch@...lanox.com,
        saeedm@...lanox.com, kafai@...com, weiwan@...gle.com
Subject: Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

On 5/31/19 3:29 PM, David Miller wrote:
> David, can you add some supplementary information to your cover letter
> et al.  which seems to be part of what Alexei is asking for and seems
> quite reasonable?
> 

It is not clear to me what more is wanted in the cover letter. His
complaints were on lack of tests. I sent those separately; they really
aren't tied to this specific set (most of them apply to the previous set
which provided the uapi and core implementation). This set is mostly
mechanical in adding wrappers to 2 fields and shoving existing code into
the else branch of 'if (fi->nh) { new code } else { existing code }'