netdev - Re: [PATCH net-next] net: sfp: Stop SFP polling during shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <031aa595-473d-e021-6339-4adae45a2a29@sedsystems.ca>
Date:   Fri, 31 May 2019 16:40:24 -0600
From:   Robert Hancock <hancock@...systems.ca>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: sfp: Stop SFP polling during shutdown

On 2019-05-31 2:12 p.m., Russell King - ARM Linux admin wrote:
> On Fri, May 31, 2019 at 01:18:02PM -0600, Robert Hancock wrote:
>> SFP device polling can cause problems during the shutdown process if the
>> parent devices of the network controller have been shut down already.
>> This problem was seen on the iMX6 platform with PCIe devices, where
>> accessing the device after the bus is shut down causes a hang.
>>
>> Stop all delayed work in the SFP driver during the shutdown process to
>> avoid this problem.
> 
> What about interrupts?

Indeed, missed that as the GPIO controller this was being used with
didn't support interrupts. Will update the patch.

-- 
Robert Hancock
Senior Software Developer
SED Systems, a division of Calian Ltd.
Email: hancock@...systems.ca