netdev - Re: [PATCH net] vrf: Increment Icmp6InMsgs on the original netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 May 2019 17:06:16 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Suryaputra <ssuryaextr@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] vrf: Increment Icmp6InMsgs on the original netdev

On 5/29/19 11:08 PM, Stephen Suryaputra wrote:
> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
> index 1a832f5e190b..9b365c345c34 100644
> --- a/net/ipv6/reassembly.c
> +++ b/net/ipv6/reassembly.c
> @@ -260,6 +260,9 @@ static int ip6_frag_reasm(struct frag_queue *fq, struct sk_buff *skb,
>  	int payload_len;
>  	u8 ecn;
>  
> +	if (netif_is_l3_master(dev))
> +		dev = dev_get_by_index_rcu(net, inet6_iif(skb));
> +
>  	inet_frag_kill(&fq->q);
>  
>  	ecn = ip_frag_ecn_table[fq->ecn];
> 

this part changes skb->dev. Seems like it has an unintended effect if
the packet is delivered locally.