netdev - Re: [RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C720F7E-5EA6-489F-8631-2DF2A4C55A01@darbyshire-bryant.me.uk>
Date:   Fri, 31 May 2019 08:29:38 +0000
From:   Kevin 'ldir' Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo

> On 30 May 2019, at 20:59, Stephen Hemminger <stephen@...workplumber.org> wrote:
> 
> On Thu, 30 May 2019 16:43:20 +0000
> Kevin 'ldir' Darbyshire-Bryant <ldir@...byshire-bryant.me.uk> wrote:
> 
> Please don't use HTML encoded mail. I.e not exchange.

As far as I know I’m not sending HTML emails, or I’m trying hard to send
plain text from mac mail, and using git send-email to send patches.
The office365 smtp server appears to be mangling patches in some way,
sending using git send-email via icloud v office365 produces different
results despite setting 8bit encoding rather than base64.  So I remain
confused.

Anyway, have sent a v2 via an icloud smtp server after your advice &
checkpatch etc etc.  Hopefully improved.

> 
>> +
>> +	if (argc) {
>> +		if (matches(*argv, "dscp") == 0) {
>> +			NEXT_ARG();
>> +			char *slash;
>> +			if ((slash = strchr(*argv, '/')))
>> +				*slash = '\0';
> 
> Don't mix assignment and conditional on same line

Checkpatch found that too :-)