netdev - Re: [PATCH v2] net: ethernet: ti: cpsw_ethtool: fix ethtool ring param set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b1b0ac9-6165-6d59-d3f7-d484705119f2@ti.com>
Date:   Sat, 1 Jun 2019 13:36:20 +0300
From:   grygorii <grygorii.strashko@...com>
To:     Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>, <davem@...emloft.net>
CC:     <linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] net: ethernet: ti: cpsw_ethtool: fix ethtool ring
 param set



On 31/05/2019 16:47, Ivan Khoronzhuk wrote:
> Fix ability to set RX descriptor number, the reason - initially
> "tx_max_pending" was set incorrectly, but the issue appears after
> adding sanity check, so fix is for "sanity" patch.
> 
> Fixes: 37e2d99b59c476 ("ethtool: Ensure new ring parameters are within bounds during SRINGPARAM")
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
> ---
> Based on net/master
> 
>   drivers/net/ethernet/ti/cpsw_ethtool.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw_ethtool.c b/drivers/net/ethernet/ti/cpsw_ethtool.c
> index a4a7ec0d2531..6d1c9ebae7cc 100644
> --- a/drivers/net/ethernet/ti/cpsw_ethtool.c
> +++ b/drivers/net/ethernet/ti/cpsw_ethtool.c
> @@ -643,7 +643,7 @@ void cpsw_get_ringparam(struct net_device *ndev,
>   	struct cpsw_common *cpsw = priv->cpsw;
>   
>   	/* not supported */
> -	ering->tx_max_pending = 0;
> +	ering->tx_max_pending = cpsw->descs_pool_size - CPSW_MAX_QUEUES;
>   	ering->tx_pending = cpdma_get_num_tx_descs(cpsw->dma);
>   	ering->rx_max_pending = cpsw->descs_pool_size - CPSW_MAX_QUEUES;
>   	ering->rx_pending = cpdma_get_num_rx_descs(cpsw->dma);
> 

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
Best regards,
grygorii