netdev - RE: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <852aa9d7989c476f81e750724c99cb10@EX13D11EUB003.ant.amazon.com>
Date:   Mon, 3 Jun 2019 14:29:13 +0000
From:   "Jubran, Samih" <sameehj@...zon.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kiyanovski, Arthur" <akiyano@...zon.com>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>
Subject: RE: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties
 retrieval via get_priv_flags



> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Thursday, May 30, 2019 10:42 PM
> To: Jubran, Samih <sameehj@...zon.com>
> Cc: netdev@...r.kernel.org; Kiyanovski, Arthur <akiyano@...zon.com>;
> Woodhouse, David <dwmw@...zon.co.uk>; Machulsky, Zorik
> <zorik@...zon.com>; Matushevsky, Alexander <matua@...zon.com>;
> Bshara, Saeed <saeedb@...zon.com>; Wilson, Matt <msw@...zon.com>;
> Liguori, Anthony <aliguori@...zon.com>; Bshara, Nafea
> <nafea@...zon.com>; Tzalik, Guy <gtzalik@...zon.com>; Belgazal,
> Netanel <netanel@...zon.com>; Saidi, Ali <alisaidi@...zon.com>;
> Herrenschmidt, Benjamin <benh@...zon.com>
> Subject: Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra
> properties retrieval via get_priv_flags
> 
> From: <sameehj@...zon.com>
> Date: Wed, 29 May 2019 12:49:55 +0300
> 
> > @@ -560,6 +564,14 @@ struct ena_admin_set_feature_mtu_desc {
> >  	u32 mtu;
> >  };
> >
> > +struct ena_admin_get_extra_properties_strings_desc {
> > +	u32 count;
> > +};
> > +
> > +struct ena_admin_get_extra_properties_flags_desc {
> > +	u32 flags;
> > +};
> 
> These single entry structures are a big overkill.  If anything just do one which
> is like "ena_value_desc" and has that "u32 val;"

We think that it's better to leave it as it is, since it's more readable when the types and fields have meaningful names,  and it also leaves place for extending it in the future.