netdev - Re: [PATCH net] selftests: set sysctl bc_forwarding properly in router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190603.151514.2135792251349356990.davem@davemloft.net>
Date:   Mon, 03 Jun 2019 15:15:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] selftests: set sysctl bc_forwarding properly in
 router_broadcast.sh

From: Xin Long <lucien.xin@...il.com>
Date: Sun,  2 Jun 2019 19:09:55 +0800

> sysctl setting bc_forwarding for $rp2 is needed when ping_test_from h2,
> otherwise the bc packets from $rp2 won't be forwarded. This patch is to
> add this setting for $rp2.
> 
> Also, as ping_test_from does grep "$from" only, which could match some
> unexpected output, some test case doesn't really work, like:
> 
>   # ping_test_from $h2 198.51.200.255 198.51.200.2
>     PING 198.51.200.255 from 198.51.100.2 veth3: 56(84) bytes of data.
>     64 bytes from 198.51.100.1: icmp_seq=1 ttl=64 time=0.336 ms
> 
> When doing grep $form (198.51.200.2), the output could still match.
> So change to grep "bytes from $from" instead.
> 
> Fixes: 40f98b9af943 ("selftests: add a selftest for directed broadcast forwarding")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied.