netdev - Re: [PATCH net-next 6/9] ptp: ptp_clock: Publish scaled_ppm_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190604142105.5ckgkxshu4lcy6zc@localhost>
Date:   Tue, 4 Jun 2019 07:21:05 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        shalomt@...lanox.com, petrm@...lanox.com, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 6/9] ptp: ptp_clock: Publish scaled_ppm_to_ppb

On Mon, Jun 03, 2019 at 03:12:41PM +0300, Ido Schimmel wrote:
> From: Shalom Toledo <shalomt@...lanox.com>
> 
> Publish scaled_ppm_to_ppb to allow drivers to use it.

But why?

> @@ -63,7 +63,7 @@ static void enqueue_external_timestamp(struct timestamp_event_queue *queue,
>  	spin_unlock_irqrestore(&queue->lock, flags);
>  }
>  
> -static s32 scaled_ppm_to_ppb(long ppm)
> +s32 ptp_clock_scaled_ppm_to_ppb(long ppm)

Six words is a little bit much for the name of a function.

Thanks,
Richard