netdev - Re: [PATCH net-next 08/18] net: axienet: Cleanup DMA device reset and halt process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190604024542.GN17267@lunn.ch>
Date:   Tue, 4 Jun 2019 04:45:42 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Robert Hancock <hancock@...systems.ca>
Cc:     netdev@...r.kernel.org, anirudh@...inx.com, John.Linn@...inx.com
Subject: Re: [PATCH net-next 08/18] net: axienet: Cleanup DMA device reset
 and halt process

On Mon, Jun 03, 2019 at 03:57:07PM -0600, Robert Hancock wrote:
> The Xilinx DMA blocks each have their own reset register, but they both
> reset the entire DMA engine, so only one of them needs to be reset.
> 
> Also, when stopping the device, we need to not just command the DMA
> blocks to stop, but wait for them to stop, and trigger a device reset
> to ensure that they are completely stopped.

Given the previous patch, does this device reset also need to take the
MDIO bus into account?

     Andrew