netdev - Re: [PATCH net-next] net: phy: add flag PHY_QUIRK_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b926b01-4473-f070-056f-75bf3cd49a74@gmail.com>
Date:   Tue, 4 Jun 2019 23:07:09 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        Robert Hancock <hancock@...systems.ca>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: add flag PHY_QUIRK_NO_ESTATEN

On 04.06.2019 15:00, Andrew Lunn wrote:
> On Tue, Jun 04, 2019 at 08:10:50AM +0200, Heiner Kallweit wrote:
>> We have a Xilinx GBit PHY that doesn't have BMSR_ESTATEN set
>> (what violates the Clause 22 standard). Instead of having the PHY
>> driver to implement almost identical copies of few generic functions
>> let's add a flag for this quirk to phylib.
> 
> Hi Heiner
> 
> It is a bit of a personal preference, but i would prefer the Xilinx
> driver worked around broken hardware, not scatter quirks in the core.
> Keep the core clean.
> 
> If we had multiple PHYs broken in the same way, then maybe a quirk.
> 
Yes, I was expecting that there may be different opinions on whether
this should be handled in the core or by the driver.
But this is obsolete now anyway after Robert figured out that his
problem actually was another one.

> 	Andrew
> 
Heiner