netdev - Re: [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190604.142436.1951250822599766015.davem@davemloft.net>
Date:   Tue, 04 Jun 2019 14:24:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org,
        syzbot+bad6e32808a3a97b1515@...kaller.appspotmail.com
Subject: Re: [PATCH net-next] net: ipv4: fix rcu lockdep splat due to wrong
 annotation

From: Florian Westphal <fw@...len.de>
Date: Mon,  3 Jun 2019 22:41:44 +0200

> syzbot triggered following splat when strict netlink
> validation is enabled:
> 
> net/ipv4/devinet.c:1766 suspicious rcu_dereference_check() usage!
> 
> This occurs because we hold RTNL mutex, but no rcu read lock.
> The second call site holds both, so just switch to the _rtnl variant.
> 
> Reported-by: syzbot+bad6e32808a3a97b1515@...kaller.appspotmail.com
> Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied.