netdev - Re: [PATCH net-next v3 07/19] net: axienet: Re-initialize MDIO registers properly after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190604221856.GB19627@lunn.ch>
Date:   Wed, 5 Jun 2019 00:18:56 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Robert Hancock <hancock@...systems.ca>
Cc:     netdev@...r.kernel.org, anirudh@...inx.com, John.Linn@...inx.com
Subject: Re: [PATCH net-next v3 07/19] net: axienet: Re-initialize MDIO
 registers properly after reset

> -	axienet_iow(lp, XAE_MDIO_MC_OFFSET,
> -		    (mdio_mcreg & (~XAE_MDIO_MC_MDIOEN_MASK)));
> +	mutex_lock(&lp->mii_bus->mdio_lock);
> +	axienet_mdio_disable(lp);

I wonder if it would look better structured if the lock was in
axienet_mdio_disable() and the unlock in axienet_mdio_enable(lp)?

As you said, you are trying to refactor all the MDIO code it mdio.c.

   Andrew