netdev - RE: [EXT] [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB3600D120E0CB743F67063F52FF150@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Tue, 4 Jun 2019 03:51:36 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Fabio Estevam <festevam@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() instead
 of pr_err()

From: Fabio Estevam <festevam@...il.com> Sent: Tuesday, June 4, 2019 11:05 AM
> dev_err() is more appropriate for printing error messages inside drivers, so
> switch to dev_err().
> 
> Signed-off-by: Fabio Estevam <festevam@...il.com>

Acked-by: Fugang Duan <fugang.duan@....com>
> ---
> Changes since v1:
> - Use dev_err() instead of netdev_err() - Andy
> 
>  drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 7e892b1cbd3d..19e2365be7d8 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int
> irq_idx)
>         fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
>         if (IS_ERR(fep->ptp_clock)) {
>                 fep->ptp_clock = NULL;
> -               pr_err("ptp_clock_register failed\n");
> +               dev_err(&pdev->dev, "ptp_clock_register failed\n");
>         }
> 
>         schedule_delayed_work(&fep->time_keep, HZ);
> --
> 2.17.1