netdev - Re: [PATCH] lib: objagg: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190605152137.GE3202@nanopsycho>
Date:   Wed, 5 Jun 2019 17:21:37 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: objagg: Use struct_size() in kzalloc()

Wed, Jun 05, 2019 at 04:45:16PM CEST, gustavo@...eddedor.com wrote:
>One of the more common cases of allocation size calculations is finding
>the size of a structure that has a zero-sized array at the end, along
>with memory for some number of elements for that array. For example:
>
>struct objagg_stats {
>	...
>        struct objagg_obj_stats_info stats_info[];
>};
>
>size = sizeof(*objagg_stats) + sizeof(objagg_stats->stats_info[0]) * count;
>instance = kzalloc(size, GFP_KERNEL);
>
>Instead of leaving these open-coded and prone to type mistakes, we can
>now use the new struct_size() helper:
>
>instance = kzalloc(struct_size(instance, stats_info, count), GFP_KERNEL);
>
>Notice that, in this case, variable alloc_size is not necessary, hence it
>is removed.
>
>This code was detected with the help of Coccinelle.
>
>Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>